New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device tracker support for EE Brightbox 2 router #19611

Merged
merged 7 commits into from Jan 22, 2019

Conversation

Projects
None yet
4 participants
@krygal
Copy link
Contributor

krygal commented Dec 27, 2018

Description:

Documentation: home-assistant/home-assistant.io#7962

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: ee_brightbox
    password: router-admin-password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Dec 27, 2018

Hi @krygal,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@wafflebot wafflebot bot added the in progress label Dec 27, 2018

@homeassistant homeassistant added cla-signed and removed cla-needed labels Dec 27, 2018

@krygal krygal force-pushed the krygal:device-tracker-eebrightbox branch 2 times, most recently from 2177704 to 56fcb11 Dec 28, 2018

@krygal krygal referenced this pull request Dec 30, 2018

Merged

Documentation for ee_brightbox device tracker #7962

0 of 2 tasks complete

@krygal krygal force-pushed the krygal:device-tracker-eebrightbox branch from 56fcb11 to b29c857 Jan 13, 2019

@MartinHjelmare MartinHjelmare changed the title Added device tracker support for EE Brightbox 2 router Add device tracker support for EE Brightbox 2 router Jan 20, 2019

krygal added some commits Jan 20, 2019

assert hass.states.get('device_tracker.hostname11') is not None
assert hass.states.get('device_tracker.hostnameff') is None

device = hass.states.get('device_tracker.hostnameaa')

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Jan 21, 2019

Member

This is a state we're getting, so please rename the variable to that.

This comment has been minimized.

@krygal

krygal Jan 21, 2019

Author Contributor

fixed

For more details about this platform, please refer to the documentation at
https://home-assistant.io/components/device_tracker.ee_brightbox/
"""

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Jan 21, 2019

Member

Remove blank line.

This comment has been minimized.

@krygal

krygal Jan 21, 2019

Author Contributor

thanks, fixed. I'm sure I run pylint and it didn't pick it up

@@ -112,6 +113,7 @@
'sqlalchemy',
'srpenergy',
'statsd',
'timeago',

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Jan 21, 2019

Member

Remove this.

This comment has been minimized.

@krygal

krygal Jan 21, 2019

Author Contributor

good catch, fixed

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 21, 2019

What's the test coverage percentage?

@krygal

This comment has been minimized.

Copy link
Contributor Author

krygal commented Jan 21, 2019

@MartinHjelmare ee_brightbox.py coverage is 95%

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit a8ef7a2 into home-assistant:dev Jan 22, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 92.929%
Details

@wafflebot wafflebot bot removed the in progress label Jan 22, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

Add device tracker support for EE Brightbox 2 router (home-assistant#…
…19611)

* Added device tracker support for EE Brightbox 2

* removed timeago dependency

* get scanner checks and improved tests

* fixed lint issues

* removed redundant timeago from test requirements

* fixed variable naming in test

* removed unecessary blank line

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Add device tracker support for EE Brightbox 2 router (home-assistant#…
…19611)

* Added device tracker support for EE Brightbox 2

* removed timeago dependency

* get scanner checks and improved tests

* fixed lint issues

* removed redundant timeago from test requirements

* fixed variable naming in test

* removed unecessary blank line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment