New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulling cpu_temp issue on Odroid #19620

Merged
merged 1 commit into from Dec 28, 2018

Conversation

Projects
None yet
4 participants
@gipnokote
Copy link
Contributor

gipnokote commented Dec 28, 2018

Description:

This is basically a similar fix as in PR #19404 but for Odroid (at least for Odroid U2 which I have). Similarly to cpu-thermal 1 on Raspberry Pi, termal sensor on Odroid is called exynos-therm 1, so I added it to the Glances component.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@mretegan

This comment has been minimized.

Copy link
Contributor

mretegan commented Dec 28, 2018

I was about to open another pull request to support the Vero 4K that I have. For this one the thermal sensor is called soc_thermal 1. Could this be added to this pull request? Hopefully at some point that list of identifiers will become exhaustive.

@fabaff

This comment has been minimized.

Copy link
Member

fabaff commented Dec 28, 2018

@mretegan, please open a PR.

@fabaff

fabaff approved these changes Dec 28, 2018

Copy link
Member

fabaff left a comment

Thanks 🐦

@fabaff fabaff merged commit 82d6fe5 into home-assistant:dev Dec 28, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.057%
Details

@wafflebot wafflebot bot removed the in progress label Dec 28, 2018

@gipnokote gipnokote deleted the gipnokote:glances-exynos-patch branch Dec 28, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 30, 2018

Merge branch 'dev' into current
* dev: (44 commits)
  Fix ADS light when parameter adsvar_brightness is not set (home-assistant#19636)
  Bump pyHik library to 0.1.9 to improve device support. (home-assistant#19656)
  Use aioharmony for remote.harmony platform (home-assistant#19595)
  Add RaspyRFM switch platform (home-assistant#19130)
  Only bind clusters in ZHA remote entity (home-assistant#19577)
  Use async_configure for ZHA IAS binary sensor (home-assistant#19629)
  Improve Wemo setup speed (home-assistant#19563)
  Support knx operation types (home-assistant#19546)
  Use xml.etree through defusedxml (home-assistant#19640)
  Fix cpu_temp issue on Vero 4K (home-assistant#19638)
  Added events STARTED, RESTARTED AND PAUSED (home-assistant#19516)
  Revert "Bump pyotgw to 0.4b0 (home-assistant#19618)" (home-assistant#19635)
  Upgrade to async_upnp_client==0.13.8 (home-assistant#19634)
  Upgraded pyarlo to 0.2.3 (home-assistant#19626)
  Fix cpu_temp issue on Odroid (home-assistant#19620)
  Bump pyotgw to 0.4b0 (home-assistant#19618)
  Add additional neato alerts and errors (home-assistant#19608)
  LCN component and light platform (home-assistant#18621)
  Systemmonitor - add device_class property (home-assistant#19614)
  Upgrade huawei-lte-api to 1.1.1 (home-assistant#19615)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment