New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ADS light when parameter adsvar_brightness is not set #19636

Merged
merged 2 commits into from Dec 30, 2018

Conversation

Projects
None yet
4 participants
@carstenschroeder
Copy link
Contributor

carstenschroeder commented Dec 29, 2018

Description:

Just a small change to prevent exception if optional parameter adsvar_brightness is not set.
(replaces #19423)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

carstenschroeder added some commits Dec 29, 2018

ADS light breaks if optional parameter adsvar_brightness is not set
Just a small change to prevent exception if optional parameter adsvar_brightness is not set
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 29, 2018

Why open a new PR? Please continue in the old PR. But separate fixes should be done in separate PRs.

@carstenschroeder

This comment has been minimized.

Copy link
Contributor

carstenschroeder commented Dec 29, 2018

@MartinHjelmare I deleted my fork of HA, because my previous fork based not directly on HA. So the old branch was gone and I didn't know how to add further commits to the PR. Sorry, I'm new to git and all the stuff.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 30, 2018

Ok, it's fine.

@MartinHjelmare MartinHjelmare changed the title ADS light breaks if optional parameter adsvar_brightness is not set Fix ADS light when parameter adsvar_brightness is not set Dec 30, 2018

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 30, 2018

Is there an issue that we should close when merging this?

@carstenschroeder

This comment has been minimized.

Copy link
Contributor

carstenschroeder commented Dec 30, 2018

Is there an issue that we should close when merging this?

No, I could not find any corresponding issue.

@MartinHjelmare MartinHjelmare merged commit 4b90ed6 into home-assistant:dev Dec 30, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.057%
Details

@wafflebot wafflebot bot removed the in progress label Dec 30, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 30, 2018

Merge branch 'dev' into current
* dev: (44 commits)
  Fix ADS light when parameter adsvar_brightness is not set (home-assistant#19636)
  Bump pyHik library to 0.1.9 to improve device support. (home-assistant#19656)
  Use aioharmony for remote.harmony platform (home-assistant#19595)
  Add RaspyRFM switch platform (home-assistant#19130)
  Only bind clusters in ZHA remote entity (home-assistant#19577)
  Use async_configure for ZHA IAS binary sensor (home-assistant#19629)
  Improve Wemo setup speed (home-assistant#19563)
  Support knx operation types (home-assistant#19546)
  Use xml.etree through defusedxml (home-assistant#19640)
  Fix cpu_temp issue on Vero 4K (home-assistant#19638)
  Added events STARTED, RESTARTED AND PAUSED (home-assistant#19516)
  Revert "Bump pyotgw to 0.4b0 (home-assistant#19618)" (home-assistant#19635)
  Upgrade to async_upnp_client==0.13.8 (home-assistant#19634)
  Upgraded pyarlo to 0.2.3 (home-assistant#19626)
  Fix cpu_temp issue on Odroid (home-assistant#19620)
  Bump pyotgw to 0.4b0 (home-assistant#19618)
  Add additional neato alerts and errors (home-assistant#19608)
  LCN component and light platform (home-assistant#18621)
  Systemmonitor - add device_class property (home-assistant#19614)
  Upgrade huawei-lte-api to 1.1.1 (home-assistant#19615)
  ...
@tomation7

This comment has been minimized.

Copy link

tomation7 commented Dec 30, 2018

Thanks for fixing it

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

@carstenschroeder carstenschroeder deleted the carstenschroeder:ads-light-patch-1 branch Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment