New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter urllib3.connectionpool warnings in camera.axis and camera.zoneminder #19641

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@rohankapoorcom
Copy link
Member

rohankapoorcom commented Dec 29, 2018

Description:

There was an existing workaround for this warning in the camera.mjpeg platform. This platform is used as a superclass for existing platforms camera.axis and camera.zoneminder. This PR exposes the workaround via a method and uses it in all platforms that subclass camera.mjpeg.

Related issue (if applicable): fixes #19600

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

For now this looks ok. For the future we should think about decoupling the platforms so they don't depend on the mjpeg camera platform. Maybe make an Mjpeg component. But that's an architecture discussion.

@MartinHjelmare MartinHjelmare merged commit c2525be into home-assistant:dev Jan 3, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 93.062%
Details

@wafflebot wafflebot bot removed the in progress label Jan 3, 2019

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:urllib3-error-filtering branch Jan 3, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 5, 2019

Merge branch 'homematicip_cloud-update_rest_api_version' into current
* homematicip_cloud-update_rest_api_version:
  Update of requirements files
  Update version to 0.10.1
  Update HAP-python to 2.4.2 (home-assistant#19776)
  update powerview scene component to latest api. (home-assistant#19717)
  Fix some ESPHome race conditions (home-assistant#19772)
  Use manufacturer id only for configure_reporting only when specified. (home-assistant#19729)
  Don't slugify unique id (home-assistant#19770)
  Support for Homekit controller/alarm control panel (home-assistant#19612)
  check config instead of config_entry for quirks flag (home-assistant#19730)
  Round illumination and lux value to one (home-assistant#19747)
  Upgrade tibber library (home-assistant#19768)
  Add mychevy optional country parameter (home-assistant#19727)
  Move envisalink component to package and add services.yaml (home-assistant#19731)
  Proactive Alexa ChangeReport messages (home-assistant#18114)
  Filter urllib3.connectionpool warnings in camera.axis and camera.zoneminder (home-assistant#19641)
  Add exception handling to ADS shutdown (home-assistant#19682)
  Drop bme680 os_lookup for temp_offset (home-assistant#19733)
  Fix WeMo incorrect mapping of device type during discovery (home-assistant#19691)
  Do not choke on no awair data (home-assistant#19708)

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

kellerza added a commit to kellerza/home-assistant that referenced this pull request Jan 18, 2019

Filter urllib3.connectionpool warnings in camera.axis and camera.zone…
…minder (home-assistant#19641)

* Filter urllib3.connectionpool warnings in camera.axis and camera.zoneminder

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment