New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in got_connected for remote.harmony #19662

Merged
merged 2 commits into from Dec 30, 2018

Conversation

Projects
None yet
4 participants
@ehendrix23
Copy link
Contributor

ehendrix23 commented Dec 30, 2018

Description:

Fixed an issue when device is reconnected and race condition for available state

Related issue (if applicable): fixes #19657

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 30, 2018

Can be merged when build passes.

@cgarwood cgarwood merged commit 43eaa96 into home-assistant:dev Dec 30, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.054%
Details

@wafflebot wafflebot bot removed the in progress label Dec 30, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 3, 2019

Merge branch 'dev' into current
* dev:
  Adds ability to calibrate temperature for BME680 (home-assistant#19684)
  Bumping aioasuswrt version to 1.1.17 (home-assistant#19714)
  Bump pyotgw to 0.4b1 (home-assistant#19715)
  Envisalink pgm (home-assistant#19499)
  Update pyhomematic 0.1.54 + small fixes (home-assistant#19667)
  Add ness alarm control panel using nessclient (home-assistant#18463)
  Add support for color_temp_command_template in MQTT light component (home-assistant#19675)
  Improve rflink coverage (home-assistant#19596)
  Luftdaten traceback (home-assistant#19666)
  Fix london_underground issue (home-assistant#19642)
  Add IDTECK proximity card component (home-assistant#18309)
  Fix homekit_controller pairing regression (home-assistant#19654)
  Fix error in got_connected for remote.harmony (home-assistant#19662)
  Fix exception checking for next dublin bus (home-assistant#19663)
  Added regexp validation allowing Twilio notifications to use Sender ID instead of phone number (home-assistant#19644)
  pytraccar version bump (home-assistant#19659)
  Suppress traceback if network is not available

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

@ehendrix23 ehendrix23 deleted the ehendrix23:Fix_config_call_in_got_connected branch Jan 12, 2019

kellerza added a commit to kellerza/home-assistant that referenced this pull request Jan 18, 2019

Fix error in got_connected for remote.harmony (home-assistant#19662)
* Fix config call in connected

* Change aioharmony version for fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment