New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyhomematic 0.1.54 + small fixes #19667

Merged
merged 3 commits into from Jan 1, 2019

Conversation

Projects
None yet
3 participants
@danielperna84
Copy link
Contributor

danielperna84 commented Dec 30, 2018

Description:

In pyhomematic:

  • Set SABOTAGE helper for HmIP devices to channel 0
  • Fix log-message for callbacks
  • Add support for HmIP-FBL, HmIP-SWDM, HmIP-SMI55

In Home Assistant:

  • Fix #19619
  • Ensure that the event we are processing is handeled by the correct entity. See this issue for further details: danielperna84/pyhomematic#193
    @pvizeli do you see anything wrong with this approach? So far it seems to work.

Related issue (if applicable): fixes #19619

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

danielperna84 added some commits Dec 30, 2018

@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Dec 30, 2018

The question would be, what is wrong on event subscription function they evaluate the correct channels and subscribe it. Theoretical, he should only subscribe to the right channel that we don't need to look every callback call like now

@danielperna84

This comment has been minimized.

Copy link
Contributor

danielperna84 commented Dec 30, 2018

I think it's shomehow related to this particular device having STATE for the actor and also as a sensor.

@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Dec 31, 2018

With the fix, we don't receive any device information like STICKY on channel 0 they we subscribe on every entity. Difficult, I will look into subscribe function, maybe we can optimize that

@danielperna84

This comment has been minimized.

Copy link
Contributor

danielperna84 commented Dec 31, 2018

You're right. I didn't notice that.
I think for the short term it would be best to leave out that fix from this PR and handle it separately.

@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Jan 1, 2019

I think we can fix that there: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/homematic/__init__.py#L832-L836

My problem is, I can't remember why we do that. I think we should be fine always to use the channel or 0 and filter others out...

@pvizeli

pvizeli approved these changes Jan 1, 2019

@pvizeli pvizeli merged commit 4244ea7 into home-assistant:dev Jan 1, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.063%
Details

@wafflebot wafflebot bot removed the in progress label Jan 1, 2019

@danielperna84 danielperna84 deleted the danielperna84:homematic branch Jan 1, 2019

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Jan 2, 2019

Update pyhomematic 0.1.54 + small fixes (home-assistant#19667)
* Update pyhomematic + small fix

* Add casting for ILLUMINATION

* Revert suggested fix

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Jan 3, 2019

Update pyhomematic 0.1.54 + small fixes (home-assistant#19667)
* Update pyhomematic + small fix

* Add casting for ILLUMINATION

* Revert suggested fix

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 3, 2019

Merge branch 'dev' into current
* dev:
  Adds ability to calibrate temperature for BME680 (home-assistant#19684)
  Bumping aioasuswrt version to 1.1.17 (home-assistant#19714)
  Bump pyotgw to 0.4b1 (home-assistant#19715)
  Envisalink pgm (home-assistant#19499)
  Update pyhomematic 0.1.54 + small fixes (home-assistant#19667)
  Add ness alarm control panel using nessclient (home-assistant#18463)
  Add support for color_temp_command_template in MQTT light component (home-assistant#19675)
  Improve rflink coverage (home-assistant#19596)
  Luftdaten traceback (home-assistant#19666)
  Fix london_underground issue (home-assistant#19642)
  Add IDTECK proximity card component (home-assistant#18309)
  Fix homekit_controller pairing regression (home-assistant#19654)
  Fix error in got_connected for remote.harmony (home-assistant#19662)
  Fix exception checking for next dublin bus (home-assistant#19663)
  Added regexp validation allowing Twilio notifications to use Sender ID instead of phone number (home-assistant#19644)
  pytraccar version bump (home-assistant#19659)
  Suppress traceback if network is not available

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

@danielperna84

This comment has been minimized.

Copy link
Contributor

danielperna84 commented Jan 11, 2019

My problem is, I can't remember why we do that. I think we should be fine always to use the channel or 0 and filter others out...

I don't remember either. How about instead of doing my first approach

if int(device.split(':')[-1]) != int(self._channel):	
    return

we do this:

eventchannel = int(device.split(':')[-1])
if eventchannel != int(self._channel) and eventchannel != 0:
    return

That should let events from the maintenance channel though, but block anything else that doesn't match the channel of the entity.

kellerza added a commit to kellerza/home-assistant that referenced this pull request Jan 18, 2019

Update pyhomematic 0.1.54 + small fixes (home-assistant#19667)
* Update pyhomematic + small fix

* Add casting for ILLUMINATION

* Revert suggested fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment