New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for color_temp_command_template in MQTT light component #19675

Merged
merged 3 commits into from Jan 1, 2019

Conversation

Projects
None yet
4 participants
@dchesterton
Copy link
Contributor

dchesterton commented Dec 31, 2018

Description:

Add support for changing the MQTT color_temp command with the color_temp_command_template config option, in the same way as the existing rgb_command_template config option. This adds support for devices which expect the color_temp to be in Kelvin, such as SmartThings and Hubitat.

Related issue (if applicable): fixes #19673 (among others)

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8000

Example entry for configuration.yaml (if applicable):

light:
  - platform: mqtt
    color_temp_command_topic: "devices/bulb/color_temp"
    color_temp_command_template: "{{ (1000 / value) | round(0) }}"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Dec 31, 2018

Hi @dchesterton,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@@ -207,6 +209,7 @@ def _setup_from_config(self, config):
self._templates = {
CONF_BRIGHTNESS: config.get(CONF_BRIGHTNESS_VALUE_TEMPLATE),
CONF_COLOR_TEMP: config.get(CONF_COLOR_TEMP_VALUE_TEMPLATE),
CONF_COLOR_TEMP_COMMAND_TEMPLATE: config.get(CONF_COLOR_TEMP_COMMAND_TEMPLATE),

This comment has been minimized.

@houndci-bot

houndci-bot Dec 31, 2018

line too long (91 > 79 characters)

@dchesterton dchesterton referenced this pull request Dec 31, 2018

Merged

Update light.mqtt.markdown #8000

2 of 2 tasks complete

@homeassistant homeassistant added cla-signed and removed cla-needed labels Dec 31, 2018

@emontnemery

This comment has been minimized.

Copy link
Contributor

emontnemery commented Dec 31, 2018

Please add an abbreviation for the new configuration variable in mqtt/discovery.py

@dchesterton dchesterton requested a review from home-assistant/core as a code owner Dec 31, 2018

@dchesterton

This comment has been minimized.

Copy link
Contributor

dchesterton commented Dec 31, 2018

Thanks, I've added the abbreviation.

@emontnemery
Copy link
Contributor

emontnemery left a comment

Looks good.

@emontnemery emontnemery merged commit 61d5b30 into home-assistant:dev Jan 1, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 93.074%
Details

@wafflebot wafflebot bot removed the in progress label Jan 1, 2019

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Jan 2, 2019

Add support for color_temp_command_template in MQTT light component (h…
…ome-assistant#19675)

* Add support for color_temp_command_template in MQTT light component

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Jan 3, 2019

Add support for color_temp_command_template in MQTT light component (h…
…ome-assistant#19675)

* Add support for color_temp_command_template in MQTT light component

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 3, 2019

Merge branch 'dev' into current
* dev:
  Adds ability to calibrate temperature for BME680 (home-assistant#19684)
  Bumping aioasuswrt version to 1.1.17 (home-assistant#19714)
  Bump pyotgw to 0.4b1 (home-assistant#19715)
  Envisalink pgm (home-assistant#19499)
  Update pyhomematic 0.1.54 + small fixes (home-assistant#19667)
  Add ness alarm control panel using nessclient (home-assistant#18463)
  Add support for color_temp_command_template in MQTT light component (home-assistant#19675)
  Improve rflink coverage (home-assistant#19596)
  Luftdaten traceback (home-assistant#19666)
  Fix london_underground issue (home-assistant#19642)
  Add IDTECK proximity card component (home-assistant#18309)
  Fix homekit_controller pairing regression (home-assistant#19654)
  Fix error in got_connected for remote.harmony (home-assistant#19662)
  Fix exception checking for next dublin bus (home-assistant#19663)
  Added regexp validation allowing Twilio notifications to use Sender ID instead of phone number (home-assistant#19644)
  pytraccar version bump (home-assistant#19659)
  Suppress traceback if network is not available

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

kellerza added a commit to kellerza/home-assistant that referenced this pull request Jan 18, 2019

Add support for color_temp_command_template in MQTT light component (h…
…ome-assistant#19675)

* Add support for color_temp_command_template in MQTT light component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment