New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mychevy optional country parameter #19727

Merged
merged 2 commits into from Jan 4, 2019

Conversation

Projects
None yet
5 participants
@sdague
Copy link
Member

sdague commented Jan 2, 2019

mychevy 1.2.0 provides the ability to work in canada as well as the us
(there are different service urls for each region). This creates a new
config option to enable it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

CONFIG_SCHEMA = vol.Schema({
DOMAIN: vol.Schema({
vol.Required(CONF_USERNAME): cv.string,
vol.Required(CONF_PASSWORD): cv.string,
vol.Optional(CONF_COUNTRY, default="us"): cv.string

This comment has been minimized.

@pvizeli

pvizeli Jan 2, 2019

Member

vol.All(cv.string, vol.In(['us', 'ca']))?

This comment has been minimized.

@sdague

sdague Jan 2, 2019

Member

Thanks! I was wondering how to do that.

Add optional country parameter
mychevy 1.2.0 provides the ability to work in canada as well as the us
(there are different service urls for each region). This creates a new
config option to enable it.

@sdague sdague force-pushed the sdague:mychevy_ca branch from fa1b536 to b209dd1 Jan 2, 2019

@frenck

This comment has been minimized.

Copy link
Member

frenck commented Jan 3, 2019

Could not find a matching documentation PR in our documentation repository. Adding docs-missing label.

@frenck frenck added the docs-missing label Jan 3, 2019

@sdague sdague referenced this pull request Jan 3, 2019

Merged

add country support to mychevy #8030

2 of 2 tasks complete
@sdague

This comment has been minimized.

Copy link
Member

sdague commented Jan 3, 2019

Docs are now added

@sdague sdague removed the docs-missing label Jan 3, 2019

@pvizeli

pvizeli approved these changes Jan 3, 2019

@MartinHjelmare MartinHjelmare changed the title Add optional country parameter Add mychevy optional country parameter Jan 3, 2019

@cgarwood cgarwood merged commit 03488af into home-assistant:dev Jan 4, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 93.073%
Details

@wafflebot wafflebot bot removed the in progress label Jan 4, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 5, 2019

Merge branch 'homematicip_cloud-update_rest_api_version' into current
* homematicip_cloud-update_rest_api_version:
  Update of requirements files
  Update version to 0.10.1
  Update HAP-python to 2.4.2 (home-assistant#19776)
  update powerview scene component to latest api. (home-assistant#19717)
  Fix some ESPHome race conditions (home-assistant#19772)
  Use manufacturer id only for configure_reporting only when specified. (home-assistant#19729)
  Don't slugify unique id (home-assistant#19770)
  Support for Homekit controller/alarm control panel (home-assistant#19612)
  check config instead of config_entry for quirks flag (home-assistant#19730)
  Round illumination and lux value to one (home-assistant#19747)
  Upgrade tibber library (home-assistant#19768)
  Add mychevy optional country parameter (home-assistant#19727)
  Move envisalink component to package and add services.yaml (home-assistant#19731)
  Proactive Alexa ChangeReport messages (home-assistant#18114)
  Filter urllib3.connectionpool warnings in camera.axis and camera.zoneminder (home-assistant#19641)
  Add exception handling to ADS shutdown (home-assistant#19682)
  Drop bme680 os_lookup for temp_offset (home-assistant#19733)
  Fix WeMo incorrect mapping of device type during discovery (home-assistant#19691)
  Do not choke on no awair data (home-assistant#19708)

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment