New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check configuration.yaml instead of config entry for ZHA enable_quirks flag #19730

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
6 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Jan 3, 2019

The original intent for this was to default the functionality to on and to let users disable it if they chose to for any reason. Moving the check to the configuration.yaml part of the configuration actually allows this to be changed without a user having to remove and re-add an integration.

@Adminiuga
Copy link
Contributor

Adminiuga left a comment

Looks good.

@cgarwood

This comment has been minimized.

Copy link
Member

cgarwood commented Jan 4, 2019

Needs a docs update with the new config option

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Can be merged when docs PR is linked in the PR description.

@dmulcahey

This comment has been minimized.

Copy link
Contributor

dmulcahey commented Jan 4, 2019

image

it's already there no? I just switched where I was checking for it. Unless I am missing something.

@cgarwood

This comment has been minimized.

Copy link
Member

cgarwood commented Jan 4, 2019

Aaah its been a long time since the last release. I was looking in current instead of next

@cgarwood cgarwood merged commit ef180c4 into home-assistant:dev Jan 4, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.096%
Details

@wafflebot wafflebot bot removed the in progress label Jan 4, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 5, 2019

Merge branch 'homematicip_cloud-update_rest_api_version' into current
* homematicip_cloud-update_rest_api_version:
  Update of requirements files
  Update version to 0.10.1
  Update HAP-python to 2.4.2 (home-assistant#19776)
  update powerview scene component to latest api. (home-assistant#19717)
  Fix some ESPHome race conditions (home-assistant#19772)
  Use manufacturer id only for configure_reporting only when specified. (home-assistant#19729)
  Don't slugify unique id (home-assistant#19770)
  Support for Homekit controller/alarm control panel (home-assistant#19612)
  check config instead of config_entry for quirks flag (home-assistant#19730)
  Round illumination and lux value to one (home-assistant#19747)
  Upgrade tibber library (home-assistant#19768)
  Add mychevy optional country parameter (home-assistant#19727)
  Move envisalink component to package and add services.yaml (home-assistant#19731)
  Proactive Alexa ChangeReport messages (home-assistant#18114)
  Filter urllib3.connectionpool warnings in camera.axis and camera.zoneminder (home-assistant#19641)
  Add exception handling to ADS shutdown (home-assistant#19682)
  Drop bme680 os_lookup for temp_offset (home-assistant#19733)
  Fix WeMo incorrect mapping of device type during discovery (home-assistant#19691)
  Do not choke on no awair data (home-assistant#19708)

@dmulcahey dmulcahey added this to the 0.85.1 milestone Jan 10, 2019

balloob added a commit that referenced this pull request Jan 11, 2019

@balloob balloob referenced this pull request Jan 11, 2019

Merged

0.85.1 #19986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment