Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup if discovered mqtt lock can't be added #19746

Merged

Conversation

Projects
None yet
4 participants
@emontnemery
Copy link
Contributor

commented Jan 3, 2019

Description:

If a discovered MQTT lock fails to be added, make sure the discovery hash is cleaned up from the ALREADY_DISCOVERED list. (Same as #19721)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@emontnemery emontnemery changed the title Cleanup if discovered mqtt lock can't be added WIP - Cleanup if discovered mqtt lock can't be added Jan 5, 2019

@emontnemery

This comment has been minimized.

Copy link
Contributor Author

commented Jan 6, 2019

@balloob Thanks for reviewing, it would be awesome if you had a look at base PR #19721

@emontnemery emontnemery force-pushed the emontnemery:mqtt_discovery_cleanup_lock branch from 5241f3d to 12faa16 Jan 7, 2019

@emontnemery emontnemery changed the title WIP - Cleanup if discovered mqtt lock can't be added Cleanup if discovered mqtt lock can't be added Jan 7, 2019

@emontnemery emontnemery merged commit bb37cf9 into home-assistant:dev Jan 8, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0009%) to 93.084%
Details

@ghost ghost removed the in progress label Jan 8, 2019

@emontnemery emontnemery deleted the emontnemery:mqtt_discovery_cleanup_lock branch Jan 19, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Cleanup if discovered mqtt lock can't be added (home-assistant#19746)
* Cleanup if discovered mqtt lock can't be added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.