New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't slugify unique id #19770

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@syssi
Copy link
Member

syssi commented Jan 4, 2019

Description:

# homeassistant 0.84.6
>>> from homeassistant.util import slugify
>>> slugify("{}-{}".format("status", "158d0002254951"))
'status158d0002254951'
>>> 
$ source bin/activate
$ pip3 install -U https://github.com/home-assistant/home-assistant/archive/dev.zip
$ python3
Python 3.5.3 (default, Jan 19 2017, 14:11:04) 
[GCC 6.3.0 20170118] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from homeassistant.util import slugify
>>> slugify("{}-{}".format("status", "158d0002254951"))
'status_158d0002254951'
>>> 

This patch will keep the old behavior/format: status158d0002254951

cp. #19192 (comment)

Related issue (if applicable): fixes #13522

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Jan 4, 2019

Is this a breaking change ?

@syssi

This comment has been minimized.

Copy link
Member

syssi commented Jan 4, 2019

No. It avoids a breaking change.

@syssi syssi added this to the 0.85.0 milestone Jan 4, 2019

@balloob balloob merged commit 65c7bdc into home-assistant:dev Jan 4, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 93.073%
Details

@wafflebot wafflebot bot removed the in progress label Jan 4, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 5, 2019

Merge branch 'homematicip_cloud-update_rest_api_version' into current
* homematicip_cloud-update_rest_api_version:
  Update of requirements files
  Update version to 0.10.1
  Update HAP-python to 2.4.2 (home-assistant#19776)
  update powerview scene component to latest api. (home-assistant#19717)
  Fix some ESPHome race conditions (home-assistant#19772)
  Use manufacturer id only for configure_reporting only when specified. (home-assistant#19729)
  Don't slugify unique id (home-assistant#19770)
  Support for Homekit controller/alarm control panel (home-assistant#19612)
  check config instead of config_entry for quirks flag (home-assistant#19730)
  Round illumination and lux value to one (home-assistant#19747)
  Upgrade tibber library (home-assistant#19768)
  Add mychevy optional country parameter (home-assistant#19727)
  Move envisalink component to package and add services.yaml (home-assistant#19731)
  Proactive Alexa ChangeReport messages (home-assistant#18114)
  Filter urllib3.connectionpool warnings in camera.axis and camera.zoneminder (home-assistant#19641)
  Add exception handling to ADS shutdown (home-assistant#19682)
  Drop bme680 os_lookup for temp_offset (home-assistant#19733)
  Fix WeMo incorrect mapping of device type during discovery (home-assistant#19691)
  Do not choke on no awair data (home-assistant#19708)

balloob added a commit that referenced this pull request Jan 9, 2019

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment