Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring for the alexa component #19782

Merged
merged 3 commits into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@abmantis
Copy link
Contributor

commented Jan 5, 2019

Description:

Some changes as sugested by balloob in #18114

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@abmantis abmantis force-pushed the abmantis:alexa_proactive_reports_fixes branch from 493771a to 61c756d Jan 7, 2019

abmantis added some commits Jan 8, 2019

@fabaff fabaff changed the title small refactoring for the alexa component Small refactoring for the alexa component Jan 10, 2019

@balloob balloob merged commit ca460ac into home-assistant:dev Jan 11, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.033%
Details

@ghost ghost removed the in progress label Jan 11, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.