New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomematicIP add cover FROLL and BROLL devices #19794

Merged
merged 12 commits into from Jan 22, 2019

Conversation

Projects
None yet
7 participants
@mxworm
Copy link
Contributor

mxworm commented Jan 5, 2019

Description:

Add support for the HmIP-FROLL and HmIP-BROLL devices

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#8170

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

mxworm added some commits Jan 5, 2019

@mxworm mxworm changed the title HomematicIP add cover FROLL and BROLL devices [WIP] HomematicIP add cover FROLL and BROLL devices Jan 7, 2019

@mxworm mxworm changed the title [WIP] HomematicIP add cover FROLL and BROLL devices HomematicIP add cover FROLL and BROLL devices Jan 9, 2019

mxworm added some commits Jan 10, 2019

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Please update the coveragerc file for the homematicip_cloud modules. The main component file was moved to a package file and is covered by tests. But the hap and device modules under the package aren't covered completely.

.coveragerc Outdated
@@ -164,7 +164,9 @@ omit =
homeassistant/components/homematic/__init__.py
homeassistant/components/*/homematic.py

homeassistant/components/homematicip_cloud.py
homeassistant/components/homematicip_cloud/__init__.py

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Jan 13, 2019

Member

This module is covered 100 %. So we can remove it.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Thanks!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 13, 2019

Can be merged when a docs PR is linked in the PR description.

@frenck frenck added the docs-missing label Jan 14, 2019

@mxworm mxworm referenced this pull request Jan 14, 2019

Merged

HomematicIP Cloud add cover devices platform #8170

2 of 2 tasks complete

@frenck frenck removed the docs-missing label Jan 21, 2019

@frenck

This comment has been minimized.

Copy link
Member

frenck commented Jan 21, 2019

@mxworm Thanks for adding the docs. 👍
@MartinHjelmare Ready

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 22, 2019

Thanks for the bump!

@MartinHjelmare MartinHjelmare merged commit 89ba374 into home-assistant:dev Jan 22, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 93.212%
Details

@wafflebot wafflebot bot removed the in progress label Jan 22, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

HomematicIP add cover FROLL and BROLL devices (home-assistant#19794)
* Add cover FROLL and BROLL devices

* Fix import

* Fix async calls

* Update cover functions and async fixes

* Update test

* Cleanup code

* Update header

* Merge imports

* Update

* Remove init

* Update coveragerc file

* Update coveragerc

@mxworm mxworm deleted the mxworm:homematicip_cloud-cover_froll_device branch Feb 3, 2019

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

@adrianoje

This comment has been minimized.

Copy link

adrianoje commented Feb 8, 2019

Great! HMIP BROLL is working now very good in HASSIO (and also in HomeKIT :-)).
Anyhow all covers are reversed (up is down and down is up) - can sombody fix this? And/or can we do anything to have it correctly working?

See also here:
https://community.home-assistant.io/t/homematic-ip-hmip-broll/85206/6

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Feb 8, 2019

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Feb 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.