New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign user to websocket connection when using legacy_api_password #19797

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
4 participants
@FlorianLudwig
Copy link
Contributor

FlorianLudwig commented Jan 5, 2019

Description:

Related issue (if applicable): fixes #19522

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Jan 5, 2019

Hi @FlorianLudwig,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Jan 5, 2019

@FlorianLudwig FlorianLudwig force-pushed the FlorianLudwig:dev branch from 5ff586c to bf42a74 Jan 5, 2019

@balloob balloob added this to the 0.85.0 milestone Jan 9, 2019

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Jan 9, 2019

Oh good catch, looks like we missed this one.

@balloob balloob merged commit 23382ab into home-assistant:dev Jan 9, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 93.083%
Details

@wafflebot wafflebot bot removed the in progress label Jan 9, 2019

balloob added a commit that referenced this pull request Jan 9, 2019

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment