Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple accounts for Google Maps device tracker #19811

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
4 participants
@ToSa27
Copy link
Contributor

ToSa27 commented Jan 6, 2019

Description:

Adding multi-account capability for the google maps device-tracker component. This is a redo of #19716 due to issues with the fork.
It might be a good idea to wait with merging until the NoneType upstream issue is fixed as the change will trigger re-fetching the cookies into the new file name even for users with only one account. This is causing issues in HA right now as well and won't get better or worse with this change but would affect more folks that currently still have a valid cookies file: #17410 #19356

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8020

Example entry for configuration.yaml (if applicable):

no change, just allowing multiple entries instead of just one

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@cgarwood

This comment has been minimized.

Copy link
Contributor

cgarwood commented Jan 18, 2019

Looks like the upstream issue was fixed. Do any requirements need updated in this PR?

@ToSa27

This comment has been minimized.

Copy link
Contributor Author

ToSa27 commented Jan 19, 2019

@cgarwood other than the locationsharinglib dependency that needs the update from 3.0.9 to 3.0.11 there should not be anything.
@balloob any advise if I should change that as part of this merge request? It's actually dealing with a different issue, hence doesn't really fit.

@balloob balloob merged commit c637bad into home-assistant:dev Feb 21, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.075%
Details

@wafflebot wafflebot bot removed the in progress label Feb 21, 2019

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 21, 2019

Sorry, for the delay. Nah, no need to include it in this PR

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.