New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EverLights light component #19817

Merged
merged 7 commits into from Jan 21, 2019

Conversation

Projects
None yet
5 participants
@joncar
Copy link
Contributor

joncar commented Jan 6, 2019

Description:

Add EverLights light component

Related issue (if applicable): n/a

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8076

Example entry for configuration.yaml (if applicable):

light:
  - platform: everlights
    hosts:
    - 192.168.1.123
    - 192.168.1.124

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
EverLights light integration. Supports single color (with color and b…
…rightness parameters) or saved pattern (with effect parameter).
@dgomes
Copy link
Member

dgomes left a comment

You should add some tests specially for those two functions: color_rgb_to_int and color_int_to_rgb

Show resolved Hide resolved homeassistant/components/light/everlights.py Outdated
Show resolved Hide resolved homeassistant/components/light/everlights.py Outdated

@joncar joncar referenced this pull request Jan 8, 2019

Merged

Initial documentation for new EverLights light component #8076

2 of 2 tasks complete
Show resolved Hide resolved homeassistant/components/light/everlights.py Outdated
Show resolved Hide resolved homeassistant/components/light/everlights.py
Show resolved Hide resolved homeassistant/components/light/everlights.py Outdated
Show resolved Hide resolved homeassistant/components/light/everlights.py Outdated
Show resolved Hide resolved tests/components/light/test_everlights.py Outdated

joncar added some commits Jan 20, 2019

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 21, 2019

Coveralls is flaky. Merging.

@MartinHjelmare MartinHjelmare merged commit 9482a63 into home-assistant:dev Jan 21, 2019

4 of 5 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 92.923%
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Jan 21, 2019

@joncar joncar deleted the joncar:user/joncar/everlights branch Jan 21, 2019

@joncar joncar restored the joncar:user/joncar/everlights branch Jan 21, 2019

@joncar joncar deleted the joncar:user/joncar/everlights branch Jan 21, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

Add EverLights light component (home-assistant#19817)
* EverLights light integration. Supports single color (with color and brightness parameters) or saved pattern (with effect parameter).

* Fix pylint parameter name warning.

* Code review feedback.

* Add tests for the two helper functions of EverLights component.

* Fixes for review feedback.

* Change test style.

* Style fixes for hound.

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Add EverLights light component (home-assistant#19817)
* EverLights light integration. Supports single color (with color and brightness parameters) or saved pattern (with effect parameter).

* Fix pylint parameter name warning.

* Code review feedback.

* Add tests for the two helper functions of EverLights component.

* Fixes for review feedback.

* Change test style.

* Style fixes for hound.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment