New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in Lutron RadioRA2 Scene support #19819

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
4 participants
@cdheiser
Copy link
Contributor

cdheiser commented Jan 6, 2019

Description:

The main lutron component was not properly passing the keypad name to the scene component, resulting in a stack trace like so:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/scene/lutron.py", line 22, in setup_platform
    (area_name, keypad_name, device, led) = scene_data
ValueError: not enough values to unpack (expected 4, got 3)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
Fix a bug in Lutron RadioRA2 Scene support
The main lutron component was not properly passing the keypad name to the scene component, resulting in a stack trace like so:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/scene/lutron.py", line 22, in setup_platform
    (area_name, keypad_name, device, led) = scene_data
ValueError: not enough values to unpack (expected 4, got 3)

@wafflebot wafflebot bot added the in progress label Jan 6, 2019

@kellerza kellerza merged commit bf4830b into home-assistant:dev Jan 6, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 93.083%
Details

@wafflebot wafflebot bot removed the in progress label Jan 6, 2019

@kellerza kellerza added this to the 0.85.0 milestone Jan 6, 2019

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

rymsha added a commit to rymsha/home-assistant that referenced this pull request Jan 12, 2019

rymsha added a commit to rymsha/home-assistant that referenced this pull request Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment