New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Daikin Component Not Loading #19823

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
6 participants
@fredrike
Copy link
Contributor

fredrike commented Jan 6, 2019

Description:

There is a missing import and typo in the Daikin setup, this fixes that.

Related issue (if applicable): fixes #19814, Daikin config setting

Example entry for configuration.yaml (if applicable):

daikin:
  hosts:
    - 10.10.3.163

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@kellerza
Copy link
Member

kellerza left a comment

Restarted the Python 3.7 job, but should pass

@fabaff fabaff merged commit 3c46543 into home-assistant:dev Jan 7, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.083%
Details

@wafflebot wafflebot bot removed the in progress label Jan 7, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 7, 2019

Should we add it to 0.85?

@fredrike

This comment has been minimized.

Copy link
Contributor

fredrike commented Jan 7, 2019

Yes please, as Daikin is broken without this.

@MartinHjelmare MartinHjelmare added this to the 0.85.0 milestone Jan 7, 2019

balloob added a commit that referenced this pull request Jan 9, 2019

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

rymsha added a commit to rymsha/home-assistant that referenced this pull request Jan 12, 2019

rymsha added a commit to rymsha/home-assistant that referenced this pull request Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment