Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state and attribute fetching in vasttrafik #19856

Merged
merged 4 commits into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@kennedyshead
Copy link
Contributor

commented Jan 7, 2019

Description:

This will take care off logic inside state and attributes properties.
As stated by @MartinHjelmare here #19792

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@MartinHjelmare
Copy link
Member

left a comment

Can be merged when build passes.

@MartinHjelmare MartinHjelmare changed the title Fixing state and attribute fetching in vasttrafik Fix state and attribute fetching in vasttrafik Jan 7, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Thanks!

@kennedyshead

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2019

Had to fix the for loop

@MartinHjelmare MartinHjelmare merged commit c7a32e5 into home-assistant:dev Jan 8, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.074%
Details

@ghost ghost removed the in progress label Jan 8, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

@kennedyshead kennedyshead deleted the kennedyshead:fix_logs_in_vtrafik_state branch Jan 25, 2019

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Fix state and attribute fetching in vasttrafik (home-assistant#19856)
* Fixing state and attribute fetching

* Fixing state and attribute fetching

* Setting None state

* Need to brreak loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.