Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for spot cleaning that was introduced in pybotvac 0.12 #19857

Merged
merged 3 commits into from Jan 11, 2019

Conversation

Projects
None yet
5 participants
@larsvinc
Copy link
Contributor

commented Jan 7, 2019

Description:

Spot cleaning was added in pybotvac version 0.12. This exposes the functionality generically to the vacuum cleaner.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • [ x ] The code change is tested and works locally.
  • [ x ] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ x ] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

commented Jan 7, 2019

Hi @larsvinc,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@dshokouhi
Copy link
Contributor

left a comment

Looks good to me, just make sure to add to the list of supported services here: https://www.home-assistant.io/components/vacuum.neato/

Don't forget to use the "next" branch :)

larsvinc added a commit to larsvinc/home-assistant.io that referenced this pull request Jan 7, 2019

@larsvinc

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

Hi @dshokouhi,

Thanks! Documentation is updated!

I am not aware of the "next branch", could you point me to some docs? Is there something I should have done differently?

Cheers!

@dshokouhi

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

@larsvinc actually it is not correct to update it in this PR. You need to submit a PR to the docs repo and link to this PR and that one in the PR template. Here is a quick link to update the Next branch.

https://github.com/home-assistant/home-assistant.io/blob/next/source/_components/vacuum.neato.markdown

You can also refer to official documentation here: https://developers.home-assistant.io/docs/en/documentation_index.html

larsvinc added a commit to larsvinc/home-assistant.io that referenced this pull request Jan 7, 2019

@larsvinc larsvinc referenced this pull request Jan 7, 2019

Merged

Added spot clean #8093

1 of 1 task complete
@larsvinc

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

Done! Thanks for the guidance :)

Highly appreciated. Lowers the bar for further contributions...

@@ -24,7 +24,7 @@
SCAN_INTERVAL = timedelta(minutes=5)

SUPPORT_NEATO = SUPPORT_BATTERY | SUPPORT_PAUSE | SUPPORT_RETURN_HOME | \
SUPPORT_STOP | SUPPORT_START | \
SUPPORT_STOP | SUPPORT_START | SUPPORT_CLEAN_SPOT\

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Jan 8, 2019

Member

Add a space between variable and backslash.

This comment has been minimized.

Copy link
@larsvinc

larsvinc Jan 8, 2019

Author Contributor

Done!

@MartinHjelmare MartinHjelmare changed the title Added support for spot cleaning that was introduced in pybotvac 0.12. Add support for spot cleaning that was introduced in pybotvac 0.12 Jan 8, 2019

@@ -24,7 +24,7 @@
SCAN_INTERVAL = timedelta(minutes=5)

SUPPORT_NEATO = SUPPORT_BATTERY | SUPPORT_PAUSE | SUPPORT_RETURN_HOME | \
SUPPORT_STOP | SUPPORT_START | \
SUPPORT_STOP | SUPPORT_START | SUPPORT_CLEAN_SPOT \

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Jan 8, 2019

Member

There is no bitwise or operator after SUPPORT_CLEAN_SPOT before the backslash. Sorry that I missed it earlier.

This comment has been minimized.

Copy link
@larsvinc

larsvinc Jan 8, 2019

Author Contributor

No, sorry for missing it. My original code had SUPPORT_CLEAN_SPOT on the last line, but I found the formatting to be more balanced with it on the middle line...

Done!

@MartinHjelmare
Copy link
Member

left a comment

Good!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jan 8, 2019

Can be merged when build passes.

@balloob balloob merged commit 82c6d3d into home-assistant:dev Jan 11, 2019

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA

@ghost ghost removed the in progress label Jan 11, 2019

fabaff added a commit to home-assistant/home-assistant.io that referenced this pull request Jan 13, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.