Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo Location -> Geolocation (comments and default group name) #19865

Merged
merged 3 commits into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@exxamalte
Copy link
Contributor

commented Jan 8, 2019

Description:

Fixed all occurrences in the source code comments from "geo location" to "geolocation", as well as in the default group name of the component; as discussed in home-assistant/architecture#42 (comment)
Left filenames and source code unchanged.

Related issue (if applicable): n/a

Pull request in home-assistant.io with documentation (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@fabaff

fabaff approved these changes Jan 8, 2019

@fabaff fabaff merged commit 4bbfc04 into home-assistant:dev Jan 8, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.082%
Details

@ghost ghost removed the in progress label Jan 8, 2019

@exxamalte exxamalte deleted the exxamalte:geolocation_naming_1 branch Jan 8, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Geo Location -> Geolocation (comments and default group name) (home-a…
…ssistant#19865)

* fixed geolocation naming in comments

* fixed geolocation naming in default group name

* fixed link to documentation (after home-assistant/home-assistant.io#8086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.