New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HomeKit Controller covers #19866

Merged
merged 17 commits into from Jan 13, 2019

Conversation

Projects
None yet
4 participants
@adrum
Copy link
Contributor

adrum commented Jan 8, 2019

Description:

This adds support for HomeKit windows, window coverings, and garage door openers to appear as covers in Home Assistant. There does not appear to be a way to send a stop command to covers in HomeKit.

CC: @mjg59

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8096

Closes #19668

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@adrum adrum referenced this pull request Jan 8, 2019

Merged

Add support for HomeKit Controller covers #8096

2 of 2 tasks complete

adrum added some commits Jan 8, 2019

@rudgr rudgr referenced this pull request Jan 9, 2019

Closed

Homekit controller garage cover support #19668

2 of 9 tasks complete

adrum added some commits Jan 9, 2019

@adrum adrum changed the title Added support for HomeKit Controller covers Add support for HomeKit Controller covers Jan 11, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 12, 2019

There are merge conflicts.

adrum added some commits Jan 12, 2019

Merge branch 'dev' into feature/homekit-controller/cover
# Conflicts:
#	homeassistant/components/homekit_controller/__init__.py
@adrum

This comment has been minimized.

Copy link
Contributor Author

adrum commented Jan 13, 2019

The merge conflicts have been resolved.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit 3b83a64 into home-assistant:dev Jan 13, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 93.021%
Details

@wafflebot wafflebot bot removed the in progress label Jan 13, 2019

@adrum adrum deleted the adrum:feature/homekit-controller/cover branch Jan 13, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Add support for HomeKit Controller covers (home-assistant#19866)
* Added support for HomeKit Controller covers

* removed copied code

* more linting fixes

* added device type to service info

* added checks for value in characteristics

* added state stopped parsing

* removed logger

* removed unused args

* fixed inits

* removed unused imports

* fixed lint issues

* fixed lint issues

* remove state_unknown

* remove validation of kwargs in homekit controller covers

* guarantee tilt position is not none before setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment