Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add btle_name attribute to devices #19915

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@cliffordwhansen
Copy link
Contributor

commented Jan 10, 2019

Added name from bluetooth device to attributes

Description:

The advertised name of the bluetooth device was missing from the attributes, so I added it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
Update googlehome.py
Added name from bluetooth device to attributes
Update homeassistant/components/device_tracker/googlehome.py
Check if key exists before assigning name

Co-Authored-By: cliffordwhansen <clifford@nighthawk.co.za>

@ludeeus ludeeus changed the title Update googlehome.py Add name attribute to devices Jan 10, 2019

@ludeeus ludeeus changed the title Add name attribute to devices Add btle_name attribute to devices Jan 10, 2019

@ludeeus ludeeus merged commit 616f23a into home-assistant:dev Jan 10, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 93.044%
Details

@ghost ghost removed the in progress label Jan 10, 2019

@cliffordwhansen cliffordwhansen deleted the cliffordwhansen:patch-1 branch Jan 11, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Add btle_name attribute to devices (home-assistant#19915)
* Update googlehome.py

Added name from bluetooth device to attributes

* Update homeassistant/components/device_tracker/googlehome.py

Check if key exists before assigning name

Co-Authored-By: cliffordwhansen <clifford@nighthawk.co.za>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.