New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't map LevelControl to light for single cluster devices. #19929

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
4 participants
@Adminiuga
Copy link
Contributor

Adminiuga commented Jan 10, 2019

Description:

Fixes #19921
We can't map a LevelControl cluster to a light for "single cluster devices". Single cluster devices should operate as single cluster devices. Zha Light however requires the "on_off" cluster with "LevelControl" cluster being optional, so we can't map LevelControl to light, because light won't have the on_off cluster.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@wafflebot wafflebot bot added the in progress label Jan 10, 2019

@dmulcahey dmulcahey added this to the 0.85.1 milestone Jan 10, 2019

@dmulcahey dmulcahey self-requested a review Jan 10, 2019

@dmulcahey dmulcahey merged commit d859c3f into home-assistant:dev Jan 10, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 93.036%
Details

@wafflebot wafflebot bot removed the in progress label Jan 10, 2019

@Adminiuga Adminiuga deleted the Adminiuga:fixes/19921-kof-light branch Jan 11, 2019

balloob added a commit that referenced this pull request Jan 11, 2019

@balloob balloob referenced this pull request Jan 11, 2019

Merged

0.85.1 #19986

rymsha added a commit to rymsha/home-assistant that referenced this pull request Jan 12, 2019

rymsha added a commit to rymsha/home-assistant that referenced this pull request Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment