New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning #19946

Merged
merged 2 commits into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

balloob commented Jan 10, 2019

Description:

Fix warning when not specifying an entity_id in a service call. We changed the constant but not the warning in the final commit of #19006.

@balloob balloob added this to the 0.85.1 milestone Jan 10, 2019

@balloob balloob requested a review from home-assistant/core as a code owner Jan 10, 2019

@wafflebot wafflebot bot added the in progress label Jan 10, 2019

@balloob balloob merged commit 8ef2f1f into dev Jan 11, 2019

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Jan 11, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-warning branch Jan 11, 2019

balloob added a commit that referenced this pull request Jan 11, 2019

Fix warning (#19946)
* Fix warning

* Update service.py

scop pushed a commit to scop/home-assistant that referenced this pull request Jan 11, 2019

Fix warning (home-assistant#19946)
* Fix warning

* Update service.py

@balloob balloob referenced this pull request Jan 11, 2019

Merged

0.85.1 #19986

rymsha added a commit to rymsha/home-assistant that referenced this pull request Jan 12, 2019

Fix warning (home-assistant#19946)
* Fix warning

* Update service.py

rymsha added a commit to rymsha/home-assistant that referenced this pull request Jan 12, 2019

Fix warning (home-assistant#19946)
* Fix warning

* Update service.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment