Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split googlehome to a component with device tracker platform #19971

Merged
merged 21 commits into from Jan 31, 2019

Conversation

@ludeeus
Copy link
Member

ludeeus commented Jan 11, 2019

Description:

  • Adds a new googlehome component, this will allow for more integration platforms for googlehome like #18586
  • Adds support to filter devices tracked by device_type (This will help with the large amount of data this tracker can return)
  • Moved from ghlocalapi to googledevices

Breaking change
The googlehome device_tracker are now configured in the new googlehome component.
If you have the device_tracker enabled you need to remove that and enable the component.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8346

Example entry for configuration.yaml (if applicable):

googlehome:
  devices:
    - host: 192.168.2.244
      rssi_threshold: -90
      device_types:
        - 1
        - 2
        - 3

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

ludeeus added some commits Jan 11, 2019

@ludeeus

This comment was marked as outdated.

Copy link
Member Author

ludeeus commented Jan 11, 2019

It looks like Travis are AWOL on this.
Here is the result of the run on my fork.
https://travis-ci.com/ludeeus/home-assistant/builds/97029216

ludeeus added some commits Jan 14, 2019

ludeeus added some commits Jan 14, 2019

ludeeus added some commits Jan 14, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 14, 2019

Can be merged when docs PR is linked in the PR description.

@ludeeus ludeeus referenced this pull request Jan 30, 2019

Merged

Change documentation for googlehome #8346

2 of 2 tasks complete
@ludeeus

This comment has been minimized.

Copy link
Member Author

ludeeus commented Jan 30, 2019

Doc change has been added, sorry for the time that took :(

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Please update .coveragerc. Sorry about forgetting that.

ludeeus added some commits Jan 31, 2019

@ludeeus

This comment has been minimized.

Copy link
Member Author

ludeeus commented Jan 31, 2019

Updated :)

Show resolved Hide resolved .coveragerc Outdated

@MartinHjelmare MartinHjelmare merged commit 632b204 into home-assistant:dev Jan 31, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 93.04%
Details

@wafflebot wafflebot bot removed the in progress label Jan 31, 2019

@ludeeus ludeeus deleted the ludeeus:googlehome branch Jan 31, 2019

@towerhand

This comment has been minimized.

Copy link

towerhand commented Feb 13, 2019

Will this make it to .88?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Feb 14, 2019

Yes!

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

@Myztillx

This comment has been minimized.

Copy link

Myztillx commented Feb 21, 2019

Is there a way to disable tracking of new devices with this component?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Feb 21, 2019

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Feb 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.