Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support next generation of the Xiaomi Mi Smart Plug (chuangmi.plug.m3) #19972

Conversation

Projects
None yet
4 participants
@syssi
Copy link
Member

commented Jan 11, 2019

Description:

Related issue (if applicable): fixes syssi/xiaomiplug#16

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8133

@syssi syssi requested a review from rytilahti as a code owner Jan 11, 2019

@ghost ghost assigned syssi Jan 11, 2019

@ghost ghost added the in progress label Jan 11, 2019

elif model in ['chuangmi.plug.m1', 'chuangmi.plug.v2',
'chuangmi.plug.hmi205']:
elif model in ['chuangmi.plug.m1', 'chuangmi.plug.m3',
'chuangmi.plug.v2', 'chuangmi.plug.hmi205']:

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 11, 2019

continuation line over-indented for visual indent

@rytilahti

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

LGTM. The tests were run successfully, but for some reason travis did not update the status here.

@rytilahti rytilahti merged commit e2f55a9 into home-assistant:dev Jan 11, 2019

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
coverage/coveralls Coverage increased (+0.008%) to 93.047%
Details

@ghost ghost removed the in progress label Jan 11, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Support next generation of the Xiaomi Mi Smart Plug (chuangmi.plug.m3) (
home-assistant#19972)

* Support next generation of the Xiaomi Mi Smart Plug (chuangmi.plug.m3)

* Fix indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.