Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LuciDeviceScanner to scan OpenWrt Luci-RPC enabled router's state. #2

Merged
merged 3 commits into from Apr 24, 2014

Conversation

@fingon
Copy link
Contributor

commented Apr 21, 2014

Just to play with it, implemented tracker for devices on Luci-based router.

For the time being, just getting MAC addresses from ARP table, and name->MAC mappings from dhcp configuration. As I'm planning to write my own logic backend for which this is sufficient, it's enough for me, but it may not work that well with the vanilla logic (due to ARP entries having short lifetime and quiet devices not sending any).

I'm not sure there's any low-power approach how to ensure that devices are present in the first place though.. (DHCP leases for example aren't that good way to track presence of hosts either.)

@balloob

This comment has been minimized.

Copy link
Member

commented Apr 21, 2014

Cool :-)

Before I can accept it I would like to see some style / code clean up changes:

  • all code has to go through the tools pep8 and pylint without generating warning/error. Among others no lines above 80 characters.
  • There are still comments and catching of exceptions related to the Tomato scanner
  • Use list comprehension instead of map to keep the code more readable:
    list(map(lambda x:x['HW address'], r.json()['result'])) can be rewritten more clear as [item['HW address'] for item in r.jsoin()['result']]
balloob added a commit that referenced this pull request Apr 24, 2014
Merge pull request #2 from fingon/luci-checker
Added LuciDeviceScanner to scan OpenWrt Luci-RPC enabled router's state.

@balloob balloob merged commit 2b071ad into home-assistant:master Apr 24, 2014

sfiorini pushed a commit to sfiorini/home-assistant that referenced this pull request Jan 4, 2015
Merge pull request home-assistant#2 from fingon/luci-checker
Added LuciDeviceScanner to scan OpenWrt Luci-RPC enabled router's state.
hansmbakker added a commit that referenced this pull request May 31, 2015
Merge pull request #2 from balloob/media-player-volume
Fixes for Chromecast volume
aa755 referenced this pull request in aa755/home-assistant Nov 14, 2016
Merge pull request #2 from aa755/gmaps
tracking accuracy, logging from a dummy account.
@andrey-git andrey-git referenced this pull request Feb 7, 2017
1 of 2 tasks complete
balloob added a commit that referenced this pull request Feb 8, 2017
Create a file for zwave workarounds. (#5798)
* Create a file for zwave workarounds. Add sensor->binary_sensor for fgfs101 (#2)

* Don't use default None

@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017

balloob added a commit that referenced this pull request Jul 18, 2019
ecobee Preset Fix (#25256)
* ecobee Preset Fix

* Celsius Fix

* Checks Fix

* Check Fix #2

* Check Fix #3
balloob added a commit that referenced this pull request Jul 18, 2019
ecobee Preset Fix (#25256)
* ecobee Preset Fix

* Celsius Fix

* Checks Fix

* Check Fix #2

* Check Fix #3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.