Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADS service "write_data_by_name": Enable use of templates for value #20024

Merged
merged 4 commits into from Jan 13, 2019

Conversation

Projects
None yet
3 participants
@carstenschroeder
Copy link
Contributor

commented Jan 12, 2019

Description:

When using data_template in a script, the template always returns strings. Service ads.write_data_by_name expects numbers, so we need to convert the string in the schema.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

carstenschroeder added some commits Dec 30, 2018

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit aae6ff8 into home-assistant:dev Jan 13, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.008%) to 93.029%
Details

@ghost ghost removed the in progress label Jan 13, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 13, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

@carstenschroeder carstenschroeder deleted the carstenschroeder:ads_service_patch_2 branch Feb 2, 2019

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.