Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MQTT platforms under the component #20050

Merged
merged 2 commits into from Jan 15, 2019
Merged

Move MQTT platforms under the component #20050

merged 2 commits into from Jan 15, 2019

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Jan 13, 2019 •
edited

Description:

Leverages #19948 to repackage most MQTT platforms into a single directory

The following are not moved by this PR:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@emontnemery emontnemery requested a review from a team as a code owner January 13, 2019 12:17
@ghost ghost assigned emontnemery Jan 13, 2019
@ghost ghost added the in progress label Jan 13, 2019
@emontnemery emontnemery changed the title WIP - Move MQTT platforms under the component Move MQTT platforms under the component Jan 13, 2019
balloob
balloob approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good start. We can discuss the others in the future. As usual there are a bunch of weird MQTT platforms 🤷‍♂️

@emontnemery emontnemery merged commit 5b53bd6 into home-assistant:dev Jan 15, 2019
@ghost ghost removed the in progress label Jan 15, 2019
@emontnemery emontnemery mentioned this pull request Jan 17, 2019
Closed
@emontnemery emontnemery deleted the mqtt_repackage branch January 19, 2019 10:27
@balloob balloob mentioned this pull request Jan 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees

@emontnemery emontnemery

Labels
cla-signed core integration: mqtt small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emontnemery @balloob @homeassistant