New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify_ssl to restful_command and switch.rest (#20199) #20207

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
3 participants
@rohankapoorcom
Copy link
Member

rohankapoorcom commented Jan 18, 2019

Description:

Add verify_ssl to restful_command and switch.rest

Related issue (if applicable): fixes #20199

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8205

Example entry for configuration.yaml (if applicable):

switch:
  - platform: rest
    resource: http://IP_ADDRESS/ENDPOINT
    verify_ssl: true

rest_command:
  example_request:
    url: 'http://example.com/'
    verify_ssl: true

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@pvizeli pvizeli merged commit 84b1fcb into home-assistant:dev Jan 18, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 92.926%
Details

@wafflebot wafflebot bot removed the in progress label Jan 18, 2019

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:restful-verify-ssl branch Jan 18, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment