Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate on/off ids on manual configured IHC lights #20253

Merged
merged 6 commits into from Mar 1, 2019

Conversation

@msvinth
Copy link
Contributor

commented Jan 19, 2019

Description:

Add support for separate on/off ids on manual configured IHC lights.
This makes it easier to support IHC code units thats relies on being
turned on and off through specific inputs.
Also adds a pulse service (ihc.pulse) that supports sending a short on/off pulse to an IHC input.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8218

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@homeassistant

This comment has been minimized.

Copy link

commented Jan 19, 2019

Hi @msvinth,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Jan 19, 2019

@homeassistant homeassistant added cla-signed and removed cla-needed labels Jan 19, 2019

@msvinth msvinth referenced this pull request Jan 20, 2019

Merged

Document on_in and off_id #8218

0 of 2 tasks complete

@msvinth msvinth force-pushed the msvinth:ihc_onoff branch from ab04a21 to cc3e898 Feb 8, 2019

Show resolved Hide resolved homeassistant/components/ihc/util.py Outdated
Show resolved Hide resolved homeassistant/components/ihc/__init__.py
Show resolved Hide resolved homeassistant/components/ihc/light.py Outdated
Show resolved Hide resolved homeassistant/components/ihc/light.py Outdated
Show resolved Hide resolved homeassistant/components/ihc/light.py Outdated
Show resolved Hide resolved homeassistant/components/ihc/light.py Outdated

@msvinth msvinth requested review from home-assistant/core as code owners Feb 26, 2019

@msvinth msvinth force-pushed the msvinth:ihc_onoff branch from 8b82eac to 3056ec6 Feb 26, 2019

@msvinth

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

Sorry everyone I asked for a review. I meshed up my git commands and did a pull instead of rebase. Only @MartinHjelmare is needed for the review.
@MartinHjelmare Sorry, but I ended up doing a force push to fix my git mistake.

@OverloadUT OverloadUT removed request for home-assistant/core, OverloadUT, ludeeus, Kane610, amelchio and cdce8p Feb 26, 2019

Show resolved Hide resolved homeassistant/components/ihc/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/ihc/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/ihc/light.py Outdated
@MartinHjelmare
Copy link
Member

left a comment

Looks good!

@MartinHjelmare MartinHjelmare changed the title Add support for separate on/off ids on manual configured IHC lights. Add separate on/off ids on manual configured IHC lights Feb 28, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Try rebasing to make the build pass.

msvinth added some commits Jan 19, 2019

Add support for separate on/off ids on manual configured IHC lights.
This makes it easier to support IHC code units thats relies on being
turned on and off through specific inputs.
Also adds a pulse service (ihc.pulse) that supports sending a short on/off pulse to an IHC input.
Fix

@msvinth msvinth force-pushed the msvinth:ihc_onoff branch from 00b8748 to c6d599e Feb 28, 2019

@msvinth

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

Did the rebasing and the build is now passing. Thank you for the review.

@MartinHjelmare MartinHjelmare merged commit 0aba49a into home-assistant:dev Mar 1, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 92.754%
Details

@ghost ghost removed the in progress label Mar 1, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.