New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LCN switch platform #20267

Merged
merged 2 commits into from Jan 20, 2019

Conversation

Projects
None yet
3 participants
@alengwenus
Copy link
Contributor

alengwenus commented Jan 20, 2019

Description:

The LCN switch platform is added. The implementation follows the already merged LCN light platform.

Related issue (if applicable):

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8223

Example entry for configuration.yaml (if applicable):

lcn:
  connections:
    - name: myhome
      host: 192.168.2.41
      port: 4114
      username: !secret lcn_username
      password: !secret lcn_password

  switches:
    - name: Sprinkler switch
      address: myhome.0.7
      output: relay1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit 7c25389 into home-assistant:dev Jan 20, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.925%
Details

@wafflebot wafflebot bot removed the in progress label Jan 20, 2019

alengwenus added a commit to alengwenus/home-assistant that referenced this pull request Jan 21, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

Add LCN switch platform (home-assistant#20267)
* Add LCN switch platform

* Added guard clause for discovery_info check and removed unnecessary parathesis

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Add LCN switch platform (home-assistant#20267)
* Add LCN switch platform

* Added guard clause for discovery_info check and removed unnecessary parathesis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment