New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo C02 to CO2 #20306

Merged
merged 5 commits into from Jan 22, 2019

Conversation

Projects
None yet
3 participants
@reefab
Copy link
Contributor

reefab commented Jan 21, 2019

Description:

There was a typo in the air quality platform, ATTR_CO2 was spelled ATTR_C02, zero instead of big o.

This attribute wasn't used anywhere so no other files needed to be changed.

I took this opportunity to add VOC, Volatile Organic Compounds to the attributes list.
Considering many, if not most, indoor air quality devices derives their CO2 measurement from a VOC sensor.

Context: I'm migrating the foobot component from sensor to the air quality platform.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

balloob added some commits Jan 22, 2019

@balloob balloob changed the title Fix typo C02 to CO2 and added VOC to air quality platform Fix typo C02 to CO2 Jan 22, 2019

@balloob
Copy link
Member

balloob left a comment

Typo fix is good.

Adding a new attribute to an entity component requires an architecture issue.

@balloob balloob merged commit d419471 into home-assistant:dev Jan 22, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 92.925%
Details

@wafflebot wafflebot bot removed the in progress label Jan 22, 2019

@reefab

This comment has been minimized.

Copy link
Contributor Author

reefab commented Jan 22, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

Fix typo C02 to CO2 (home-assistant#20306)
* Fix type C02 to CO2 and added VOC to air quality platform

* singularized volatile_organic_compound

* Remove VOC prop

* Update __init__.py

* Update __init__.py

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Fix typo C02 to CO2 (home-assistant#20306)
* Fix type C02 to CO2 and added VOC to air quality platform

* singularized volatile_organic_compound

* Remove VOC prop

* Update __init__.py

* Update __init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment