New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return windspeed and windgust in km/h instead of m/s. #20340

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
3 participants
@jvanderneutstulen
Copy link
Contributor

jvanderneutstulen commented Jan 23, 2019

Description:

Darksky dev docs state (https://darksky/dev/docs):
ca: same as si, except that windSpeed and windGust are in kilometers per hour

This change will make the output in sync with https://developers.home-assistant.io/docs/en/entity_weather.html when the unit_system is metric

Related issue (if applicable): #16793

Example entry for configuration.yaml (if applicable):

homeassistant:
  latitude: !secret ha_latitude
  longitude: !secret ha_longitude
  elevation: !secret ha_elevation
  unit_system: metric

weather: 
  - platform: darksky
    api_key: !secret darksky_apikey
    mode: daily

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
Return windspeed and windgust in km/h instead of m/s.
Darksky dev docs state (https://darksky/dev/docs):
`ca: same as si, except that windSpeed and windGust are in kilometers per
hour`

@jvanderneutstulen jvanderneutstulen requested a review from fabaff as a code owner Jan 23, 2019

@wafflebot wafflebot bot added the in progress label Jan 23, 2019

@balloob balloob merged commit 55943cf into home-assistant:dev Jan 25, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 93.112%
Details

@wafflebot wafflebot bot removed the in progress label Jan 25, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

Return windspeed and windgust in km/h instead of m/s. (home-assistant…
…#20340)

Darksky dev docs state (https://darksky/dev/docs):
`ca: same as si, except that windSpeed and windGust are in kilometers per
hour`

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Return windspeed and windgust in km/h instead of m/s. (home-assistant…
…#20340)

Darksky dev docs state (https://darksky/dev/docs):
`ca: same as si, except that windSpeed and windGust are in kilometers per
hour`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment