New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for blink initialization failure. Fixes #20335 #20351

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
5 participants
@fronzbot
Copy link
Contributor

fronzbot commented Jan 23, 2019

Description:

Due to upstream API endpoint changes for Blink, the current integration fails to load. I have a fix in the blinkpy library to handle this error until a long term fix is in (ie. finding the new endpoint). This fix allows for everything in the Blink home-assistant component to continue working except for motion detection.

Breaking Change:
Blink motion detection temporarily broken due to API change.

blinkpy change log: https://github.com/fronzbot/blinkpy/releases/tag/v0.11.2

Related issue (if applicable): fixes #20335

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@dgomes

@fronzbot

This comment has been minimized.

Copy link
Contributor Author

fronzbot commented Jan 23, 2019

So the cov test failed and I'm not sure why. The failure is unrelated to any commits I made, as far as I can tell. Any ideas?

@dgomes

This comment has been minimized.

Copy link
Member

dgomes commented Jan 23, 2019

@balloob currently blink is broken for all previous versions, any chance of cutting this into 0.86 ?

@Danielhiversen Danielhiversen added this to the 0.86.0 milestone Jan 23, 2019

@Danielhiversen

This comment has been minimized.

Copy link
Member

Danielhiversen commented Jan 23, 2019

Please add a link to the change log of the library to the pr description

@Danielhiversen Danielhiversen merged commit 7ca7951 into home-assistant:dev Jan 23, 2019

4 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Jan 23, 2019

@fronzbot fronzbot deleted the fronzbot:blink-hotfix branch Jan 23, 2019

@fronzbot

This comment has been minimized.

Copy link
Contributor Author

fronzbot commented Jan 23, 2019

@balloob seems like this just missed the window for 0.86. Currently the Blink platform does not work without this change, any chance for a 0.86.1 bugfix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment