New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Time reporting incorrect in sensor.gtt #20362

Merged
merged 6 commits into from Jan 24, 2019

Conversation

Projects
None yet
4 participants
@eliseomartelli
Copy link
Contributor

eliseomartelli commented Jan 23, 2019

Description:

Fix time reporting incorrect on sensor.gtt.

There was a problem that slipped though testing:
datetime years were displayed as year 1900.

I've added a method to set the current day, month and year so it's possible to use the sensor.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

eliseomartelli added some commits Jan 23, 2019

eliseomartelli added some commits Jan 23, 2019

@eliseomartelli

This comment has been minimized.

Copy link
Contributor Author

eliseomartelli commented Jan 23, 2019

@balloob balloob added this to the 0.86.1 milestone Jan 24, 2019

@balloob balloob merged commit 971d933 into home-assistant:dev Jan 24, 2019

4 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 93.112%
Details

@wafflebot wafflebot bot removed the in progress label Jan 24, 2019

balloob added a commit that referenced this pull request Jan 24, 2019

[FIX] Time reporting incorrect in sensor.gtt (#20362)
* quick fix

* remove print statement

* fixes

* remove lambda

* added pylint disable

* should be fine now

@balloob balloob referenced this pull request Jan 24, 2019

Merged

0.86.1 #20369

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

[FIX] Time reporting incorrect in sensor.gtt (home-assistant#20362)
* quick fix

* remove print statement

* fixes

* remove lambda

* added pylint disable

* should be fine now

@eliseomartelli eliseomartelli deleted the eliseomartelli:fixgtttime branch Jan 29, 2019

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

[FIX] Time reporting incorrect in sensor.gtt (home-assistant#20362)
* quick fix

* remove print statement

* fixes

* remove lambda

* added pylint disable

* should be fine now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment