New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when API doesn't return a forecast. #20365

Merged
merged 2 commits into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@dgomes
Copy link
Member

dgomes commented Jan 24, 2019

Description:

Seldomly the API will not return a forecast, this makes sure we don't throw an error.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

weather:
  - platform: ipma

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Jan 24, 2019

@balloob balloob added this to the 0.86.1 milestone Jan 24, 2019

@balloob balloob merged commit 074fcd9 into home-assistant:dev Jan 24, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 93.104%
Details

@wafflebot wafflebot bot removed the in progress label Jan 24, 2019

balloob added a commit that referenced this pull request Jan 24, 2019

@balloob balloob referenced this pull request Jan 24, 2019

Merged

0.86.1 #20369

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment