New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restore state crashing invalid entity ID #20367

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

balloob commented Jan 24, 2019

Description:

Restore state would crash when loading when the stored states contained invalid entity IDs.

Related issue (if applicable): fixes #20366

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.86.1 milestone Jan 24, 2019

@balloob balloob requested a review from home-assistant/core as a code owner Jan 24, 2019

@wafflebot wafflebot bot added the in progress label Jan 24, 2019

@rbflurry

This comment has been minimized.

Copy link
Contributor

rbflurry commented Jan 24, 2019

FWIW this fix worked for me. 86 will now start successfully.

@rbflurry

This comment has been minimized.

Copy link
Contributor

rbflurry commented Jan 24, 2019

Update... It allowed HASS to boot but all the automation are now disabled. The correct state was not restored.

@balloob balloob merged commit af3afb6 into dev Jan 24, 2019

6 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 93.105%
Details

@wafflebot wafflebot bot removed the in progress label Jan 24, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-restore-state branch Jan 24, 2019

@balloob

This comment has been minimized.

Copy link
Member Author

balloob commented Jan 24, 2019

@rbflurry states will not be correctly restored if the name is different from before. Double underscore is no longer allowed. etc. However, this issue is not the place to discuss such things.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jan 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.