New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary warning from Philips Hue #20394

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
4 participants
@starkillerOG
Copy link
Contributor

starkillerOG commented Jan 24, 2019

Description:

for white hue bulbs and bulbs from other brands like Ikea and Innr, this warning will be issued while this is not really a problem.
So just remove the warning.
If the color gamut cannot be retrieved the gamut will be set to "None" and theirefore the color util will just ignore the whole gamut in the conversion and work just like it used to work before this upgrade.
Theirfore this warning is anoying and unnesesarry.
sorry my bad.

Related issue (if applicable): fixes #20379

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Philips Hue - Remove unnessesary warning
for white hue bulbs and bulbs from other brands like Ikea and Innr, this warning will be issued while this is not really a problem.
So just remove the warning.
@starkillerOG

This comment has been minimized.

Copy link
Contributor Author

starkillerOG commented Jan 24, 2019

@amelchio can you merge this as soon as travis finishes?

@amelchio amelchio added this to the 0.86.2 milestone Jan 24, 2019

@fabaff fabaff changed the title Philips Hue - Remove unnessesary warning Remove unnecessary warning from Philips Hue Jan 24, 2019

@amelchio amelchio merged commit c508ba1 into home-assistant:dev Jan 24, 2019

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Jan 24, 2019

balloob added a commit that referenced this pull request Jan 25, 2019

Philips Hue - Remove unnessesary warning (#20394)
for white hue bulbs and bulbs from other brands like Ikea and Innr, this warning will be issued while this is not really a problem.
So just remove the warning.

@balloob balloob referenced this pull request Jan 25, 2019

Merged

0.86.2 #20402

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

Philips Hue - Remove unnessesary warning (home-assistant#20394)
for white hue bulbs and bulbs from other brands like Ikea and Innr, this warning will be issued while this is not really a problem.
So just remove the warning.

merc1031 pushed a commit to merc1031/home-assistant that referenced this pull request Jan 29, 2019

Philips Hue - Remove unnessesary warning (home-assistant#20394)
for white hue bulbs and bulbs from other brands like Ikea and Innr, this warning will be issued while this is not really a problem.
So just remove the warning.

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Philips Hue - Remove unnessesary warning (home-assistant#20394)
for white hue bulbs and bulbs from other brands like Ikea and Innr, this warning will be issued while this is not really a problem.
So just remove the warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment