New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history allowed to load states with invalid entity IDs #20399

merged 1 commit into from Jan 25, 2019


None yet
2 participants
Copy link

balloob commented Jan 24, 2019


Yet another slugify fallout… history would contain invalid IDs, which are convered to HA States before being rendered as JSON (yes, that's very inefficient and we should fix that, but not in this PR).

Exception would occur when converting to native, as it blew up on the invalid entity ID. Solution is to temporarily allow history to disable the slugify validation when restoring states.

Related issue (if applicable): fixes #20371


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Jan 24, 2019

@wafflebot wafflebot bot added the in progress label Jan 24, 2019

@balloob balloob added this to the 0.86.2 milestone Jan 24, 2019

@balloob balloob merged commit c7f5beb into dev Jan 25, 2019

6 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
coverage/coveralls Coverage remained the same at 93.11%

@wafflebot wafflebot bot removed the in progress label Jan 25, 2019

@delete-merged-branch delete-merged-branch bot deleted the history-allow-invalid-entity-id branch Jan 25, 2019

balloob added a commit that referenced this pull request Jan 25, 2019

@balloob balloob referenced this pull request Jan 25, 2019


0.86.2 #20402

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

merc1031 pushed a commit to merc1031/home-assistant that referenced this pull request Jan 29, 2019

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment