New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Philips Hue, include debug message for color gamut #20455

Merged
merged 1 commit into from Jan 26, 2019

Conversation

Projects
None yet
4 participants
@starkillerOG
Copy link
Contributor

starkillerOG commented Jan 26, 2019

Description:

Include a debug message for troubleshooting regarding color gamuts.

Related issue (if applicable): helps debug #20447

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@rohankapoorcom

This comment has been minimized.

Copy link
Member

rohankapoorcom commented Jan 26, 2019

This doesn't actually fix #20447, just provides more information to track down the root cause. Editing the description to reflect that.

@rohankapoorcom
Copy link
Member

rohankapoorcom left a comment

Thanks

@rohankapoorcom rohankapoorcom merged commit b9bf696 into home-assistant:dev Jan 26, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0001%) to 93.119%
Details

@wafflebot wafflebot bot removed the in progress label Jan 26, 2019

@rohankapoorcom rohankapoorcom added this to the 0.86.3 milestone Jan 26, 2019

@rohankapoorcom

This comment has been minimized.

Copy link
Member

rohankapoorcom commented Jan 26, 2019

@balloob I added the 0.86.3 milestone since this will provide information needed to understand what's broken with color gamuts and hue.

balloob added a commit that referenced this pull request Jan 26, 2019

@balloob balloob referenced this pull request Jan 26, 2019

Merged

0.86.3 #20485

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

fredrike added a commit to fredrike/home-assistant that referenced this pull request Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment