New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tellduslive device info #20530

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
4 participants
@fredrike
Copy link
Contributor

fredrike commented Jan 28, 2019

Description:

Fixes issue when the API does not report model and/or protocol, which causes device_info to crash.

Related issue (if applicable): fixes #20387

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good!

@fredrike fredrike force-pushed the fredrike:tellduslive-device_info branch from 4293dac to fba9b7f Jan 28, 2019

@fredrike fredrike force-pushed the fredrike:tellduslive-device_info branch from fba9b7f to 1f168e6 Jan 28, 2019

@fredrike fredrike force-pushed the fredrike:tellduslive-device_info branch from 1f168e6 to 4cde83d Jan 28, 2019

@fredrike

This comment has been minimized.

Copy link
Contributor Author

fredrike commented Jan 28, 2019

@MartinHjelmare all done and tested by the users with the issue. Please make this available as soon as possible. (0.86.4)

@fredrike fredrike closed this Jan 28, 2019

@wafflebot wafflebot bot removed the in progress label Jan 28, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 28, 2019

Should we reopen and merge?

@fredrike

This comment has been minimized.

Copy link
Contributor Author

fredrike commented Jan 28, 2019

Yes please. Apparently did even the client cause issues.

@fredrike fredrike reopened this Jan 28, 2019

@wafflebot wafflebot bot added the in progress label Jan 28, 2019

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Thanks!

@MartinHjelmare MartinHjelmare changed the title Tellduslive device info fix Fix Tellduslive device info Jan 28, 2019

@MartinHjelmare MartinHjelmare added this to the 0.86.4 milestone Jan 28, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 28, 2019

Can be merged when build passes.

Since we're close to a beta, I don't think there will be a 0.86.4, but you never know.

@balloob balloob merged commit 717a0c2 into home-assistant:dev Jan 29, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 92.994%
Details

@wafflebot wafflebot bot removed the in progress label Jan 29, 2019

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Jan 29, 2019

I'll make one.

balloob added a commit that referenced this pull request Jan 29, 2019

@balloob balloob referenced this pull request Jan 29, 2019

Merged

0.86.4 #20559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment