Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Philips Hue: add prompt to update bridge/bulb #20590

Merged
merged 4 commits into from Jan 30, 2019

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Jan 29, 2019

Description:

add a check to check if their is an update available for the lights used in HomeAssistant.
If an update is available, issue a warning in the log to promt users to update their Philips Hue Bridge/bulbs through the Hue App.

Related issue (if applicable): this is related to issue: #20447
Actually that issue is already fixed in HomeAssistant 0.86.4. This will just make the warning messages a bit nicer.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Jan 29, 2019
@starkillerOG
Copy link
Contributor Author

This PR depends on the PR in aiohue: home-assistant-libs/aiohue#15

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge when it includes update to aiohue 1.9.0

@starkillerOG
Copy link
Contributor Author

@balloob I think this can be merged now.

@balloob
Copy link
Member

balloob commented Jan 30, 2019

Thanks!

@balloob balloob merged commit 349de19 into home-assistant:dev Jan 30, 2019
@ghost ghost removed the in progress label Jan 30, 2019
@balloob balloob mentioned this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed integration: hue small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants