New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allow extra in locative webhook schema validation #20657

Merged
merged 2 commits into from Feb 1, 2019

Conversation

@rohankapoorcom
Copy link
Member

rohankapoorcom commented Feb 1, 2019

Description:

Locative sends several extra keys that we don't care about when it sends the webhook request. Since we hadn't set extra=vol.ALLOW_EXTRA or defined those keys in the schema, it was getting rejected. Since we don't care about the values in those keys, we should just allow the extra keys to be sent.

Related issue (if applicable): fixes #20566

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@MartinHjelmare MartinHjelmare changed the title Allow extra in locative webhook schema validation (fixes #20566) Fix allow extra in locative webhook schema validation Feb 1, 2019

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Thanks!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Feb 1, 2019

Can be merged when build passes.

@rohankapoorcom rohankapoorcom merged commit 3e2dae6 into home-assistant:dev Feb 1, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on locative-webhook-fix at 93.044%
Details

@wafflebot wafflebot bot removed the in progress label Feb 1, 2019

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:locative-webhook-fix branch Feb 1, 2019

@rohankapoorcom rohankapoorcom modified the milestones: 0.87.0, 0.86.5 Feb 1, 2019

balloob added a commit that referenced this pull request Feb 2, 2019

Fix allow extra in locative webhook schema validation (#20657)
* Allow extra in locative webhook schema validation (fixes #20566)

* Remove extra attribute

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment