New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud webhook body #20739

Merged
merged 3 commits into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@pvizeli
Copy link
Member

pvizeli commented Feb 4, 2019

Description:

I change it to text because we only support text as response and aioHttp perform the correct charset that not need to be utf-8 like we set now static.

Fix:

Error handling message
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/cloud/iot.py", line 237, in _handle_connection
    hass, self.cloud, msg['handler'], msg['payload'])
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/cloud/iot.py", line 293, in async_handle_message
    return (yield from handler(hass, cloud, payload))
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/cloud/iot.py", line 366, in async_handle_webhook
    body = body.decode('utf-8')
AttributeError: 'StringPayload' object has no attribute 'decode'

@pvizeli pvizeli requested a review from home-assistant/core as a code owner Feb 4, 2019

@wafflebot wafflebot bot added the in progress label Feb 4, 2019

@pvizeli

This comment has been minimized.

Copy link
Member Author

pvizeli commented Feb 4, 2019

Address comments from #20737 after the commit and linter destroy the branch

@pvizeli pvizeli force-pushed the fix-cloud-webhook-body branch from d595682 to 3a292de Feb 4, 2019

@balloob

balloob approved these changes Feb 4, 2019

@balloob balloob added this to the 0.87.0 milestone Feb 4, 2019

@balloob balloob merged commit 29b64d5 into dev Feb 4, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Feb 4, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-cloud-webhook-body branch Feb 4, 2019

balloob added a commit that referenced this pull request Feb 5, 2019

Fix cloud webhook body (#20739)
* Bugfix cloud webhooks text response

* address comments

* Fix lint

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment