Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose effect_list attribute for turned off lights #20750

Merged

Conversation

Projects
None yet
3 participants
@OleksandrBerchenko
Copy link
Contributor

OleksandrBerchenko commented Feb 4, 2019

Description:

Related issue: fixes #20583

Expose effect_list attribute for all lights regardless of state (not only for turned on lights).

Another PR into home-assistant-polymer repo will follow right now.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Feb 4, 2019

Hi @OleksandrBerchenko,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@rohankapoorcom
Copy link
Member

rohankapoorcom left a comment

Looks good! 💯

@rohankapoorcom rohankapoorcom merged commit bdea222 into home-assistant:dev Feb 19, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0001%) to 93.357%
Details

@wafflebot wafflebot bot removed the in progress label Feb 19, 2019

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.