Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_config component #20799

Merged
merged 3 commits into from Feb 8, 2019

Conversation

@balloob
Copy link
Member

balloob commented Feb 7, 2019

Description:

Add a new "default_config" component. The sole purpose of this component is to configure the system with defaults. This allows us to amend the default config in the future, without requiring people to update their configuration.

This will avoid situations like with the introduction of system_health, where we have to ask users to update their configuration.yaml.

If users don't like our defaults, they can remove it from configuration.yaml and add the components manually, like before.

This is backwards compatible, only new users moving forward will opt-in for the new default_config component.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Is the test database included on purpose?

@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Feb 7, 2019

Why not moving to integration as a future step? Currently, we have no mechanics for this step. So that is okay now.

@balloob

This comment has been minimized.

Copy link
Member Author

balloob commented Feb 7, 2019

Oops, removed test DB. Didn't mock out recorder properly.

@balloob

This comment has been minimized.

Copy link
Member Author

balloob commented Feb 7, 2019

I don't want to move it to a config entry at this point, because these are things I want to have set up regardless of config entries.

@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Feb 7, 2019

Make sense that is to match core relevant.

@pvizeli

pvizeli approved these changes Feb 7, 2019

@balloob balloob merged commit e59240f into dev Feb 8, 2019

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on default-config at 93.355%
Details

@wafflebot wafflebot bot removed the in progress label Feb 8, 2019

@delete-merged-branch delete-merged-branch bot deleted the default-config branch Feb 8, 2019

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.