New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STATE_UNLOCKED for verisure #20858

Merged
merged 1 commit into from Feb 8, 2019

Conversation

@Danielhiversen
Copy link
Member

Danielhiversen commented Feb 8, 2019

Description:

FIx bug from #20337

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@pvizeli

pvizeli approved these changes Feb 8, 2019

@pvizeli pvizeli merged commit 6a78ad8 into dev Feb 8, 2019

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.372%
Details

@wafflebot wafflebot bot removed the in progress label Feb 8, 2019

@delete-merged-branch delete-merged-branch bot deleted the verisure branch Feb 8, 2019

@@ -80,7 +80,7 @@ def update(self):
"$.doorLockStatusList[?(@.deviceLabel=='%s')].lockedState",
self._device_label)
if status == 'UNLOCKED':
self._state = None
self._state = STATE_UNLOCKED

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Feb 8, 2019

Member

We should instead remove the state property in the verisure lock entity class, and implement is_locked. Lock platforms should not overwrite the state property.

balloob added a commit that referenced this pull request Feb 10, 2019

@balloob balloob referenced this pull request Feb 10, 2019

Merged

0.87.1 #20930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment