New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zm-py to 0.3.3 to fix event counts #20886

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Projects
None yet
5 participants
@mnoorenberghe
Copy link
Contributor

mnoorenberghe commented Feb 9, 2019

@rohankapoorcom I assume you're fine with this.

Description:

Handles an empty array being returned from the array when an object is normally expected. This is a quirk in the ZM API.

Related issue (if applicable): fixes #20833

@rohankapoorcom
Copy link
Member

rohankapoorcom left a comment

Good to merge once tests pass.

@MartinHjelmare MartinHjelmare merged commit 33d607b into home-assistant:dev Feb 9, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.353%
Details

@wafflebot wafflebot bot removed the in progress label Feb 9, 2019

@mnoorenberghe

This comment has been minimized.

Copy link
Contributor Author

mnoorenberghe commented Feb 10, 2019

@rohankapoorcom Should we backport this to 87 to fix the regression?

@rohankapoorcom rohankapoorcom added this to the 0.87.1 milestone Feb 10, 2019

@rohankapoorcom

This comment has been minimized.

Copy link
Member

rohankapoorcom commented Feb 10, 2019

Good call, tagged it for the 0.87.1 hotfix.

balloob added a commit that referenced this pull request Feb 10, 2019

@balloob balloob referenced this pull request Feb 10, 2019

Merged

0.87.1 #20930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment